Speed up CommonSingleServiceTest#5258
Merged
kenjis merged 1 commit intocodeigniter4:developfrom Nov 1, 2021
Merged
Conversation
paulbalandan
force-pushed
the
common-single-service
branch
from
61b92de to
d7364cd
Compare
MGatner
approved these changes
Nov 1, 2021
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
I assume these static variables don't fall under the newly-deprecated kind that we are removing for 8.1, right? Because the method is static?
Member
|
@MGatner These static variables are not problem. The problem may occurs only when inherited.
|
kenjis
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: